Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public input verification #34

Merged
merged 23 commits into from
Feb 2, 2024
Merged

Public input verification #34

merged 23 commits into from
Feb 2, 2024
+177 −18

Conversation

tiagofneto
Copy link
Contributor

Closes #9

@tiagofneto tiagofneto self-assigned this Jan 3, 2024
@tiagofneto tiagofneto marked this pull request as ready for review January 10, 2024 21:27
@neotheprogramist
Copy link
Contributor

@tiagofneto
You actually might want to use structs without Serde - they are distributed along the repo for example StarkWitness is in src/stark.cairo.
Additionally structs with Serde are only in deserialization directory now - there is no input_structs module anymore.

Okm165
Okm165 reviewed Jan 12, 2024
View reviewed changes
src/air/public_input.cairo Outdated Show resolved Hide resolved
Okm165
Okm165 reviewed Jan 12, 2024
View reviewed changes
src/air/public_input.cairo Outdated Show resolved Hide resolved
Okm165
Okm165 reviewed Jan 12, 2024
View reviewed changes
src/air/public_input.cairo Outdated Show resolved Hide resolved
Okm165
Okm165 reviewed Jan 12, 2024
View reviewed changes
src/air/public_memory.cairo Outdated Show resolved Hide resolved
@Okm165
Copy link
Collaborator

Okm165 commented Jan 12, 2024 •
edited
Loading

@tiagofneto
logic looks good just couple of minor suggestions from my side 👍🏼
and as @neotheprogramist said pls adjust it to latest file structure

@tiagofneto tiagofneto requested a review from Okm165 January 16, 2024 15:58
@tiagofneto
Copy link
Contributor Author

@Okm165 addressed your comments and fixed the issues with Serde

Okm165
Okm165 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@Okm165 Okm165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagofneto tiagofneto merged commit 3d99b76 into main Feb 2, 2024
2 checks passed
@tiagofneto tiagofneto deleted the feat/public-input-verify branch February 2, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okm165 Okm165 Okm165 approved these changes

Assignees

@tiagofneto tiagofneto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify public input
3 participants
@tiagofneto @neotheprogramist @Okm165